Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: raise minimum version of Node to v14.17 #248

Merged
merged 13 commits into from Sep 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
Expand Up @@ -13,9 +13,8 @@ jobs:
strategy:
matrix:
node-version:
- 10
- 12
- 14
- 14.17
- 16
os:
- ubuntu-latest
- macos-latest
Expand All @@ -28,6 +27,8 @@ jobs:
with:
node-version: "${{ matrix.node-version }}"
cache: npm
- name: Ensure dependencies are compatible with the version of node
run: echo 'engine-strict=true' >> .npmrc
- run: npm ci
- run: "npm run test:ci"
test:
Expand Down
2 changes: 1 addition & 1 deletion index.js
Expand Up @@ -14,7 +14,7 @@ const DEFAULT_RELEASE_RULES = require('./lib/default-release-rules');
*
* @param {Object} pluginConfig The plugin configuration.
* @param {String} pluginConfig.preset conventional-changelog preset ('angular', 'atom', 'codemirror', 'ember', 'eslint', 'express', 'jquery', 'jscs', 'jshint')
* @param {String} pluginConfig.config Requierable npm package with a custom conventional-changelog preset
* @param {String} pluginConfig.config Requirable npm package with a custom conventional-changelog preset
* @param {String|Array} pluginConfig.releaseRules A `String` to load an external module or an `Array` of rules.
* @param {Object} pluginConfig.parserOpts Additional `conventional-changelog-parser` options that will overwrite ones loaded by `preset` or `config`.
* @param {Object} context The semantic-release context.
Expand Down
2 changes: 1 addition & 1 deletion lib/load-parser-config.js
Expand Up @@ -8,7 +8,7 @@ const conventionalChangelogAngular = require('conventional-changelog-angular');
*
* @param {Object} pluginConfig The plugin configuration.
* @param {Object} pluginConfig.preset conventional-changelog preset ('angular', 'atom', 'codemirror', 'ember', 'eslint', 'express', 'jquery', 'jscs', 'jshint')
* @param {String} pluginConfig.config Requierable npm package with a custom conventional-changelog preset
* @param {String} pluginConfig.config Requirable npm package with a custom conventional-changelog preset
* @param {Object} pluginConfig.parserOpts Additionnal `conventional-changelog-parser` options that will overwrite ones loaded by `preset` or `config`.
* @param {Object} context The semantic-release context.
* @param {String} context.cwd The current working directory.
Expand Down
1,145 changes: 611 additions & 534 deletions package-lock.json

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions package.json
Expand Up @@ -27,18 +27,18 @@
"devDependencies": {
"ava": "3.15.0",
"conventional-changelog-atom": "2.0.8",
"conventional-changelog-conventionalcommits": "4.5.0",
"conventional-changelog-conventionalcommits": "4.6.1",
"conventional-changelog-ember": "2.0.9",
"conventional-changelog-eslint": "3.0.9",
"conventional-changelog-express": "2.0.6",
"conventional-changelog-jshint": "2.0.9",
"nyc": "15.1.0",
"semantic-release": "17.3.9",
"sinon": "11.1.1",
"semantic-release": "17.4.7",
"sinon": "11.1.2",
"xo": "0.28.3"
},
"engines": {
"node": ">=10.18"
"node": ">=14.17"
},
"files": [
"lib",
Expand Down Expand Up @@ -70,7 +70,7 @@
"all": true
},
"peerDependencies": {
"semantic-release": ">=16.0.0 <18.0.0"
"semantic-release": ">=18.0.0-beta.1"
},
"prettier": {
"printWidth": 120,
Expand Down
4 changes: 2 additions & 2 deletions test/integration.test.js
Expand Up @@ -111,7 +111,7 @@ test('Exclude commits if they have a matching revert commits', async t => {
t.true(t.context.log.calledWith('Analysis of %s commits complete: %s release', 3, 'patch'));
});

test('Accept a "releaseRules" option that reference a requierable module', async t => {
test('Accept a "releaseRules" option that reference a requirable module', async t => {
const commits = [
{hash: '123', message: 'fix(scope1): First fix'},
{hash: '456', message: 'feat(scope2): Second feature'},
Expand Down Expand Up @@ -356,7 +356,7 @@ test('Throw error if "releaseRules" is not an Array or a String', async t => {
});
});

test('Throw error if "releaseRules" option reference a requierable module that is not an Array or a String', async t => {
test('Throw error if "releaseRules" option reference a requirable module that is not an Array or a String', async t => {
await t.throwsAsync(analyzeCommits({releaseRules: './test/fixtures/release-rules-invalid'}, {cwd}), {
message: /Error in commit-analyzer configuration: "releaseRules" must be an array of rules/,
});
Expand Down
4 changes: 2 additions & 2 deletions test/load-release-rules.test.js
Expand Up @@ -10,7 +10,7 @@ test('Accept a "releaseRules" option', t => {
t.deepEqual(releaseRules, testReleaseRules);
});

test('Accept a "releaseRules" option that reference a requierable module', t => {
test('Accept a "releaseRules" option that reference a requirable module', t => {
const releaseRules = loadReleaseRules({releaseRules: './test/fixtures/release-rules'}, {cwd});

t.deepEqual(releaseRules, testReleaseRules);
Expand Down Expand Up @@ -57,7 +57,7 @@ test('Throw error if "releaseRules" is not an Array or a String', t => {
});
});

test('Throw error if "releaseRules" option reference a requierable module that is not an Array or a String', t => {
test('Throw error if "releaseRules" option reference a requirable module that is not an Array or a String', t => {
t.throws(() => loadReleaseRules({releaseRules: './test/fixtures/release-rules-invalid'}, {cwd}), {
message: /Error in commit-analyzer configuration: "releaseRules" must be an array of rules/,
});
Expand Down