Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: label must be defined for url object #397

Closed
wants to merge 1 commit into from
Closed

docs: label must be defined for url object #397

wants to merge 1 commit into from

Conversation

kaerbr
Copy link
Contributor

@kaerbr kaerbr commented Jun 7, 2022

I tried to improve the docs. What do you guys think?

Closes #393

@fgreinacher
Copy link
Contributor

Thanks a lot for your contribution @kaerbr!

For symmetry with the existing logic for file links, I prefer to go forward with #401.

Happy to get your thoughts on the documentation changes done there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing (?) feature "allow adding URLs to release assets"
2 participants