fix(fail): properly parse issue creation response to log in terminal #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JonasSchubert, the changes looks good. Can you please fix the email/signature in your commit so that GitHub is happy? 🙇 
|
🙈 sorry. work email and private open source email. Will fix that later today or tomorrow latest. |
|
@fgreinacher Updated email and gpg. Thanks for realising that 🙇 |
fgreinacher
reviewed
Feb 20, 2024
fgreinacher
reviewed
Feb 20, 2024
fgreinacher
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Thanks @JonasSchubert, had a look at the changes again and maybe we can simplify the test a bit :)
JonasSchubert
force-pushed
the
fix/properly-parse-create-fail-issue
branch
from
9224517
to
4014f51
Compare
fgreinacher
approved these changes
Feb 20, 2024
|
🎉 This PR is included in version 13.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized in our logs, the
idandweb_urlare not parsed properly. According to the docs the call to the method.json()was missing. Local tests showed this fixed the logs and did not affect the normal functionality.