fix: return false if the npm publish is skipped

semantic-release · Dec 14, 2018 · 4a41228 · 4a41228
1 parent 2786cf2
commit 4a41228
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/publish.js b/lib/publish.js
@@ -41,4 +41,6 @@ module.exports = async ({npmPublish, pkgRoot}, pkg, context) => {
       npmPublish === false ? 'npmPublish' : "package.json's private property"
     } is ${npmPublish !== false}`
   );
+
+  return false;
 };
diff --git a/test/integration.test.js b/test/integration.test.js
@@ -333,7 +333,7 @@ test('Create the package and skip publish ("npmPublish" is false)', async t => {
     }
   );
 
-  t.falsy(result);
+  t.false(result);
   t.is((await readJson(path.resolve(cwd, 'package.json'))).version, '1.0.0');
   t.true(await pathExists(path.resolve(cwd, `tarball/${pkg.name}-1.0.0.tgz`)));
   await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env: testEnv}));
@@ -363,7 +363,7 @@ test('Create the package and skip publish ("package.private" is true)', async t
     }
   );
 
-  t.falsy(result);
+  t.false(result);
   t.is((await readJson(path.resolve(cwd, 'package.json'))).version, '1.0.0');
   t.true(await pathExists(path.resolve(cwd, `tarball/${pkg.name}-1.0.0.tgz`)));
   await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env: testEnv}));
@@ -388,7 +388,7 @@ test('Create the package and skip publish from a sub-directory ("npmPublish" is
     }
   );
 
-  t.falsy(result);
+  t.false(result);
   t.is((await readJson(path.resolve(cwd, 'dist/package.json'))).version, '1.0.0');
   t.true(await pathExists(path.resolve(cwd, `tarball/${pkg.name}-1.0.0.tgz`)));
   await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env: testEnv}));
@@ -418,7 +418,7 @@ test('Create the package and skip publish from a sub-directory ("package.private
     }
   );
 
-  t.falsy(result);
+  t.false(result);
   t.is((await readJson(path.resolve(cwd, 'dist/package.json'))).version, '1.0.0');
   t.true(await pathExists(path.resolve(cwd, `tarball/${pkg.name}-1.0.0.tgz`)));
   await t.throws(execa('npm', ['view', pkg.name, 'version'], {cwd, env: testEnv}));