Merge branch 'master' into beta

lib/verify-auth.js

@@ -17,7 +17,7 @@ module.exports = async (pluginConfig, pkg, context) => {
   if (normalizeUrl(registry) === normalizeUrl(DEFAULT_NPM_REGISTRY)) {
     try {
       await execa('npm', ['whoami', '--registry', registry], {cwd, env});
-    } catch (error) {
+    } catch (_) {
       throw new AggregateError([getError('EINVALIDNPMTOKEN', {registry})]);
     }
   }

package.json

@@ -37,7 +37,7 @@
     "clear-module": "^4.0.0",
     "codecov": "^3.0.0",
     "delay": "^4.0.0",
-    "dockerode": "^2.5.3",
+    "dockerode": "^3.0.0",
     "get-stream": "^5.0.0",
     "got": "^9.0.0",
     "nyc": "^14.0.0",
@@ -46,7 +46,7 @@
     "sinon": "^7.1.1",
     "stream-buffers": "^3.0.2",
     "tempy": "^0.3.0",
-    "xo": "^0.24.0"
+    "xo": "^0.25.0"
   },
   "engines": {
     "node": ">=8.15"

test/helpers/npm-registry.js

@@ -39,7 +39,7 @@ async function start() {
       minTimeout: 1000,
       factor: 2,
     });
-  } catch (error) {
+  } catch (_) {
     throw new Error(`Couldn't start npm-docker-couchdb after 2 min`);
   }
 

test/integration.test.js

@@ -25,6 +25,11 @@ test.before(async () => {
   await npmRegistry.start();
 });
 
+test.after.always(async () => {
+  // Stop the local NPM registry
+  await npmRegistry.stop();
+});
+
 test.beforeEach(t => {
   // Clear npm cache to refresh the module state
   clearModule('..');
@@ -36,11 +41,6 @@ test.beforeEach(t => {
   t.context.logger = {log: t.context.log};
 });
 
-test.after.always(async () => {
-  // Stop the local NPM registry
-  await npmRegistry.stop();
-});
-
 test('Skip npm auth verification if "npmPublish" is false', async t => {
   const cwd = tempy.directory();
   const env = {NPM_TOKEN: 'wrong_token'};