Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#504): npm publish fails / npm publish <folder> publishes from cwd folder #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(#504): npm publish fails / npm publish <folder> publishes from cwd folder #531

wants to merge 1 commit into from

Conversation

Badisi
Copy link

@Badisi Badisi commented Dec 3, 2022

Fixes #504

@Badisi
Copy link
Author

Badisi commented Dec 17, 2022

Anyone ? please

Badisi added a commit to Badisi/auth-js that referenced this pull request Jan 12, 2023
@Badisi
fix(publish): locally patch semantic-release-npm until issue is resolved
a4c4bb8 
See: semantic-release/npm#531
@greglbd
Copy link

greglbd commented May 6, 2023

This is a great solution! I just ran and tested it and even tried your suggested patch.

greglbd
greglbd approved these changes May 6, 2023
View reviewed changes
Copy link

@greglbd greglbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the conflict and test report is resolved this looks like a winner.

I've tested this in 2 monorepos using lerna and this solves my problems with pkgRoot not being honoured.

greglbd
greglbd reviewed May 6, 2023
View reviewed changes
lib/publish.js
['publish', basePath, '--userconfig', npmrc, '--tag', distTag, '--registry', registry],
{cwd, env, preferLocal: true}
['publish', '--userconfig', npmrc, '--tag', distTag, '--registry', registry],
{cwd: basePath, env, preferLocal: true}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd like to point out that when we specify tarballDir it doesn't suffer the same problem and it's because it uses exactly this solution in the prepare.js file see: https://github.com/semantic-release/npm/blob/master/lib/prepare.js#L14-L22

@greglbd greglbd mentioned this pull request May 6, 2023
Open
@Badisi
Copy link
Author

Badisi commented May 25, 2023

@greglbd, thanks for testing that up, I appreciate 😉

@travi, I don't like having to ping someone, but since it's been 6 months already, could we have at least a word from you on this issue please ? Thanks 😊

@bdelaforest bdelaforest mentioned this pull request Nov 22, 2023
Merged
@fadler82
Copy link

fadler82 commented Dec 7, 2023

any progress here? I have the same issue and would like to get rid of this patch

@mario-jerkovic
Copy link

@gr2m Is there any chance to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglbd greglbd greglbd approved these changes

@Grabowski-M Grabowski-M Grabowski-M approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm publish fails / npm publish <folder> publishes from cwd folder
5 participants
@Badisi @greglbd @fadler82 @mario-jerkovic @Grabowski-M