-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade conventional commits #640
Conversation
Please make sure our tests are passing. |
package.json
Outdated
"conventional-changelog-atom": "^5.0.0", | ||
"conventional-changelog-conventionalcommits": "^8.0.0", | ||
"conventional-changelog-ember": "^5.0.0", | ||
"conventional-changelog-eslint": "^6.0.0", | ||
"conventional-changelog-express": "^5.0.0", | ||
"conventional-changelog-jshint": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep dev dependencies pinned to specific versions
@icco the tests continue to fail after your follow up to pin the dev dependencies. are you interested in working through the breaking changes related to these updates in order to help us move this forward? |
Yeah been trying to get the tests pass locally with no luck. I believe there's an underlying bug in the import plugin you use but can not figure it out. |
appreciate the update and the investigation. we are starting to investigate as well, but unsure how much time we can dedicate soon. please feel free to keep us up to date if you make progress, even if that means pushing wip changes that dont get to a point of getting tests to a passing state. it could also be helpful to start with running the integration tests ( |
appreciate the investment here, but closing in favor of #643. we could still use help updating the commit-analyzer plugin in similar ways in case you are still interested and the other PR helps with any complexities that you encountered with this effort |
This closes the following: