Skip to content

Commit

Permalink
fix: remove unnecessary branch parameter from push function
Browse files Browse the repository at this point in the history
  • Loading branch information
pvdlg committed Nov 30, 2018
1 parent b729183 commit 968b996
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions index.js
Expand Up @@ -108,7 +108,7 @@ async function run(context, plugins) {

logger.log('Create tag %s', nextRelease.gitTag);
await tag(nextRelease.gitTag, nextRelease.gitHead, {cwd, env});
await push(options.repositoryUrl, context.branch.name, {cwd, env});
await push(options.repositoryUrl, {cwd, env});
context.branch.tags.push({
version: nextRelease.version,
channel: nextRelease.channel,
Expand Down Expand Up @@ -164,7 +164,7 @@ async function run(context, plugins) {
} else {
// Create the tag before calling the publish plugins as some require the tag to exists
await tag(nextRelease.gitTag, nextRelease.gitHead, {cwd, env});
await push(options.repositoryUrl, context.branch.name, {cwd, env});
await push(options.repositoryUrl, {cwd, env});
logger.success(`Created tag ${nextRelease.gitTag}`);
}

Expand Down
3 changes: 1 addition & 2 deletions lib/git.js
Expand Up @@ -229,12 +229,11 @@ async function tag(tagName, ref, execaOpts) {
* Push to the remote repository.
*
* @param {String} repositoryUrl The remote repository URL.
* @param {String} branch The branch to push.
* @param {Object} [execaOpts] Options to pass to `execa`.
*
* @throws {Error} if the push failed.
*/
async function push(repositoryUrl, branch, execaOpts) {
async function push(repositoryUrl, execaOpts) {
await execa('git', ['push', '--tags', repositoryUrl], execaOpts);
}

Expand Down
4 changes: 2 additions & 2 deletions test/git.test.js
Expand Up @@ -194,7 +194,7 @@ test('Push tag to remote repository', async t => {
const commits = await gitCommits(['Test commit'], {cwd});

await tag('tag_name', 'HEAD', {cwd});
await push(repositoryUrl, 'master', {cwd});
await push(repositoryUrl, {cwd});

t.is(await gitRemoteTagHead(repositoryUrl, 'tag_name', {cwd}), commits[0].hash);
});
Expand All @@ -208,7 +208,7 @@ test('Push tag to remote repository with remote branch ahead', async t => {
await gitPush('origin', 'master', {cwd: tmpRepo});

await tag('tag_name', 'HEAD', {cwd});
await push(repositoryUrl, 'master', {cwd});
await push(repositoryUrl, {cwd});

t.is(await gitRemoteTagHead(repositoryUrl, 'tag_name', {cwd}), commits[0].hash);
});
Expand Down

0 comments on commit 968b996

Please sign in to comment.