Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(marked): reverted upgrade to v3 #2087

Merged
merged 3 commits into from Aug 23, 2021
Merged

fix(marked): reverted upgrade to v3 #2087

merged 3 commits into from Aug 23, 2021

Conversation

travi
Copy link
Member

@travi travi commented Aug 23, 2021 •
edited

since marked v3 requires node v12

@travi travi requested a review from a team August 23, 2021 19:30
@travi travi mentioned this pull request Aug 23, 2021
Merged
1 task
gr2m
gr2m reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add marked to be ignored by renovate? We'd need to configure it in package.json's "renovate" object

@travi travi mentioned this pull request Aug 23, 2021
Closed
@travi
Copy link
Member Author

travi commented Aug 23, 2021

should we add marked to be ignored by renovate?

i'd rather renovate keep us aware that there is an upgrade, but fail the build if it would be incompatible. it looks like the build is failing properly now, but i missed something else that isnt compatible with node v10. tracking that piece down now

@travi
Copy link
Member Author

travi commented Aug 23, 2021

i'm reverting the switch to use ls-engines because it revealed that we have a few other engines compatibility issues to resolve before we can make that change. i will follow up with those adjustments in a separate PR

@travi travi requested a review from gr2m August 23, 2021 20:32
@travi travi merged commit 5edff69 into master Aug 23, 2021
@travi travi deleted the revert-marked-v3 branch August 23, 2021 20:34
@github-actions
Copy link

🎉 This PR is included in version 17.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ThibaultVlacich
Copy link

Wouldn't it be better to allow both versions? ^2.0.0 || ^3.0.0

@github-actions
Copy link

🎉 This PR is included in version 18.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@travi @ThibaultVlacich @gr2m