New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): Use cosmiconfig defaults to support .cjs config files #1815
feat(config): Use cosmiconfig defaults to support .cjs config files #1815
Conversation
This change adds support for `*.cjs` config files by removing the explicit use of `searchPlaces` options and relying and the default search places generated by `cosmicconfig`. As per the docs for [`cosmicconfig`][cc], the defaults include all the extensions/formats previously supported by semantic-release in addition to the new .cjs variants. Resolves [semantic-release#1814][issue]. [issue]: semantic-release#1814 [cc]: https://github.com/davidtheclark/cosmiconfig#searchplaces
a473f31
to
440a6b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me 👍🏼
thank you for investigating and tracking down these details. i did dig a little bit to try to understand why they were defined explicitly before, but even the version that resulted in the addition appears to have supported similar defaults. from what i can tell this change aligns with the original intent fro before that change too. |
🎉 This PR is included in version 17.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This change adds support for
*.cjs
config files by removing the explicit use ofsearchPlaces
options and relying and the default search places generated bycosmicconfig
. As per the docs forcosmicconfig
, the defaults include all the extensions/formats previously supported by semantic-release in addition to the new .cjs variants.Resolves #1814.