Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forced plugins to use beta version of semantic-release #2606

Merged
merged 1 commit into from Nov 11, 2022
Merged

Conversation

travi
Copy link
Member

@travi travi commented Nov 11, 2022

for #2543

which deduped env-ci to the esm-only version, allowing test double to stub properly
Comment on lines +78 to +80
"overrides": {
"semantic-release": "20.0.0-beta.1"
},
Copy link
Member Author

@travi travi Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should target removing this before promoting the pre-release of core to stable, but it saved the dance of updating the plugins to allow a peer of the beta for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! I didn't know overrides was a thing! It's only supported in npm 8.3+ though, right?
https://www.stefanjudis.com/today-i-learned/how-to-override-your-dependencys-dependencies/

Or was it backported?

@travi travi marked this pull request as ready for review November 11, 2022 17:15
@travi travi merged commit 78ea3ba into beta Nov 11, 2022
@travi travi deleted the travi/esm branch November 11, 2022 18:03
@github-actions
Copy link

🎉 This PR is included in version 20.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

🎉 This PR is included in version 20.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants