Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: aligned pluginName with naming for functions #2610

Merged
merged 1 commit into from Nov 16, 2022
Merged

test: aligned pluginName with naming for functions #2610

merged 1 commit into from Nov 16, 2022

Conversation

travi
Copy link
Member

@travi travi commented Nov 13, 2022

based on

const pluginName = name.pluginName ? name.pluginName : isFunction(name) ? `[Function: ${name.name}]` : name;
, i think this test was wrong before and this change fixes it. i think i read the logic correctly, but the fact that this test has been the other way for a long time makes my confidence low that this is the right change, so i could really use a sanity check on this one.

for #2543

@travi travi requested a review from gr2m November 13, 2022 07:06
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me

@travi travi merged commit 0ab8d9a into beta Nov 16, 2022
@travi travi deleted the index-test branch November 16, 2022 03:59
@github-actions
Copy link

🎉 This PR is included in version 20.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

🎉 This PR is included in version 20.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants