Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets-masking): used the proper named import from hook-std to enable masking for stderr #2619

Merged
merged 2 commits into from Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/semantic-release.js
Expand Up @@ -37,7 +37,6 @@ execa('git', ['--version'])
process.exit(1);
});

// Node 10+ from this point on
cli()
.then((exitCode) => {
process.exitCode = exitCode;
Expand Down
4 changes: 2 additions & 2 deletions index.js
Expand Up @@ -2,7 +2,7 @@ import {createRequire} from 'node:module';
import {pick} from 'lodash-es';
import * as marked from 'marked';
import envCi from 'env-ci';
import {hookStdout} from 'hook-std';
import {hookStd} from 'hook-std';
import semver from 'semver';
import AggregateError from 'aggregate-error';
import hideSensitive from './lib/hide-sensitive.js';
Expand Down Expand Up @@ -251,7 +251,7 @@ async function callFail(context, plugins, err) {
}

export default async (cliOptions = {}, {cwd = process.cwd(), env = process.env, stdout, stderr} = {}) => {
const {unhook} = hookStdout(
const {unhook} = hookStd(
{silent: false, streams: [process.stdout, process.stderr, stdout, stderr].filter(Boolean)},
hideSensitive(env)
);
Expand Down
2 changes: 1 addition & 1 deletion lib/plugins/pipeline.js
Expand Up @@ -23,7 +23,7 @@ import {extractErrors} from '../utils.js';
* @param {Function} [options.getNextInput=identity] Function called after each step is executed, with the last step input and the current current step result; the returned value will be used as the input of the next step.
* @param {Function} [options.transform=identity] Function called after each step is executed, with the current step result, the step function and the last step input; the returned value will be saved in the pipeline results.
*
* @return {Pipeline} A Function that execute the `steps` sequencially
* @return {Pipeline} A Function that execute the `steps` sequentially
*/
export default (steps, {settleAll = false, getNextInput = identity, transform = identity} = {}) => async (input) => {
const results = [];
Expand Down