Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aggregate error v4 #2631

Closed
wants to merge 4 commits into from
Closed

fix: aggregate error v4 #2631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62f0611
test: emulate aggregate-error v4
hongaar Dec 5, 2022
65defa6
fix: extract errors from errors property
hongaar Dec 5, 2022
fbab2ab
chore: nits
hongaar Dec 5, 2022
d4eec55
Merge branch 'master' into fix/aggregate-error
hongaar Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ const semver = require('semver');
const hideSensitive = require('./hide-sensitive');

function extractErrors(err) {
return err && isFunction(err[Symbol.iterator]) ? [...err] : [err];
return err.errors && isFunction(err.errors[Symbol.iterator])
? [...err.errors]
: err && isFunction(err[Symbol.iterator])
? [...err]
: [err];
}

function hideSensitiveValues(env, objs) {
Expand Down
5 changes: 5 additions & 0 deletions test/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ test('extractErrors', (t) => {

t.deepEqual(extractErrors(new AggregateError(errors)), errors);
t.deepEqual(extractErrors(errors[0]), [errors[0]]);

// aggregate-error v4 stores errors in an `errors` property
const aggregateErrorv4 = new Error();
aggregateErrorv4.errors = errors;
t.deepEqual(extractErrors(aggregateErrorv4), errors);
});

test('tagsToVersions', (t) => {
Expand Down