Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update onboarding flow #1549

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Update onboarding flow #1549

merged 7 commits into from
Jun 4, 2024

Conversation

s-santillan
Copy link
Collaborator

@s-santillan s-santillan commented May 14, 2024 •
edited

Thanks for improving Semgrep Docs 😀

Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR
  • This change has no security implications or else you have pinged the security team
  • Redirects are added if the PR changes page URLs
  • If you have changed any header tag links (doc/#this-kind-of-anchor), update all instances of that link

This PR...

  • Reduces the screenshots. We're actively making changes to the onboarding process and while not finalized the screenshots get stale very quickly. We can add more screenshots when the onboarding changes are done.
  • Updates the SCM connection steps in alignment with the latest changes to the product.

@s-santillan s-santillan self-assigned this May 14, 2024
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited

✅ Deploy Preview for semgrep-docs-prod ready!

Name Link
🔨 Latest commit 9b37454
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/665f0c63a568bd0008f4472d
😎 Deploy Preview https://deploy-preview-1549--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@s-santillan s-santillan marked this pull request as ready for review May 22, 2024 13:04
@s-santillan s-santillan requested a review from khorne3 June 3, 2024 15:23
khorne3
khorne3 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@khorne3 khorne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, but other than that, this looks good.

docs/deployment/create-account-and-orgs.md Outdated Show resolved Hide resolved
@s-santillan @khorne3
Update docs/deployment/create-account-and-orgs.md
9b37454 
Co-authored-by: Katie Horne <katie.horne@semgrep.com>
@s-santillan s-santillan merged commit 1e37ecf into main Jun 4, 2024
7 checks passed
@s-santillan s-santillan deleted the sara/tec-9-update-scm-connection-docs-for-github-esp-personal-accounts branch June 4, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinat101 sinat101 sinat101 approved these changes

@khorne3 khorne3 khorne3 approved these changes

@swati-sharma swati-sharma Awaiting requested review from swati-sharma

Assignees

@s-santillan s-santillan

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s-santillan @sinat101 @khorne3