Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KB] Add monorepo example config #1551

Merged
merged 6 commits into from
May 24, 2024
Merged

[KB] Add monorepo example config #1551

merged 6 commits into from
May 24, 2024

Conversation

sinat101
Copy link
Collaborator

@sinat101 sinat101 commented May 15, 2024 •
edited

Thanks for improving Semgrep Docs 😀

Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR
  • This change has no security implications or else you have pinged the security team
  • Redirects are added if the PR changes page URLs
  • If you have changed any header tag links (doc/#this-kind-of-anchor), update all instances of that link

@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited

✅ Deploy Preview for semgrep-docs-prod ready!

Name Link
🔨 Latest commit 1b4e45e
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/6650b5a2e15b030008032cdd
😎 Deploy Preview https://deploy-preview-1551--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

armchairlinguist
armchairlinguist approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@armchairlinguist armchairlinguist left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend jettisoning the **, but other than that it's fine, and they don't break anything, so pre-approving.

docs/kb/semgrep-ci/scan-monorepo-in-parts.md Outdated Show resolved Hide resolved
docs/kb/semgrep-ci/scan-monorepo-in-parts.md Outdated Show resolved Hide resolved
@sinat101 sinat101 merged commit 3f63f0c into main May 24, 2024
7 checks passed
@sinat101 sinat101 deleted the sina/kb/add-monorepo-example-config branch May 24, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armchairlinguist armchairlinguist armchairlinguist approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sinat101 @armchairlinguist