Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up docs homepage #1552

Merged
merged 13 commits into from
May 21, 2024
Merged

clean up docs homepage #1552

merged 13 commits into from
May 21, 2024

Conversation

khorne3
Copy link
Collaborator

@khorne3 khorne3 commented May 16, 2024 •
edited

Please ensure

  • A technical writer reviews the content or PR
  • This change has no security implications or else you have pinged the security team

@netlify Netlify
Copy link

netlify bot commented May 16, 2024 •
edited

✅ Deploy Preview for semgrep-docs-prod ready!

Name Link
🔨 Latest commit 395c625
🔍 Latest deploy log https://app.netlify.com/sites/semgrep-docs-prod/deploys/664b418c09f4750008476437
😎 Deploy Preview https://deploy-preview-1552--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pabloest
pabloest approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@pabloest pabloest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks really good. I left a couple of questions in comments below but they are more for my education and context.

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
khorne3 and others added 2 commits May 16, 2024 11:04
@khorne3 @pabloest
fix typo
45e41b3 
Co-authored-by: Pablo Estrada <pablo@semgrep.com>
@khorne3
delete delete
996b13b
pabloest
pabloest reviewed May 17, 2024
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
milanwilliams
milanwilliams reviewed May 17, 2024
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
@khorne3 @pabloest
Update description
71ad888 
Co-authored-by: Pablo Estrada <pablo@semgrep.com>
khorne3
khorne3 commented May 20, 2024
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
@khorne3 khorne3 removed the request for review from s-santillan May 20, 2024 12:27
@khorne3 khorne3 merged commit e08f943 into main May 21, 2024
7 checks passed
@khorne3 khorne3 deleted the khorne3/tec-34-clean-up-docs-homepage branch May 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloest pabloest pabloest approved these changes

@milanwilliams milanwilliams milanwilliams approved these changes

@chushili1 chushili1 Awaiting requested review from chushili1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khorne3 @pabloest @milanwilliams