Make notice about leading zeros clearer #282
Conversation
It was very unclear to me that "must not contain leading zeroes" is referring to "non-negative integers" rather than to "A normal version number". First (correct) interpretation would disallow 1.01.1, second (incorrect) would disallow 0.1.0. I tried to make it more explicit here.
|
Never had a problem with that, nor heard of anyone who did. Edit: Though, I can see how the comma makes it ambiguous. |
|
Well, perhaps it's just me |
|
Honestly, I'm not really sure that the change clarifies anything. |
|
Besides the contents of this PR, I also support the point of improving the meaning of |
|
After re-reading, I agree that this change is a bit easier to understand. Disregard my last. |
|
Of course, I don't think my current edit is ideal, and I am pretty sure someone could suggest further improvements. |
| non-negative integers, and MUST NOT contain leading zeroes. X is the | ||
| major version, Y is the minor version, and Z is the patch version. | ||
| non-negative integers. Elements (X, Y and Z) MUST NOT contain leading zeroes. | ||
| X is the major version, Y is the minor version, and Z is the patch version. |
There was a problem hiding this comment.
How about just changing it from the "...MUST NOT contain leading zeroes..." in the original as:
...except for a single character ('0') place holder, MUST NOT contain leading zeroes.
There was a problem hiding this comment.
This is implied. A single 0 number does not have leading zeroes since the single zero digit is required here. This is universally understood in all other occasions I've seen this being discussed in one way or another.
I also dislike the phrasing of '0' being a "place holder", since it's clearly not.
There was a problem hiding this comment.
KISS:
A normal version number MUST take the form X.Y.Z where X, Y, and Z are non-negative integers.
X, Y, and Z MUST NOT contain leading zeroes.
alexandrtovmach
added
the
spelling/grammar
|
Closing & re-opening to trigger CI |
alexandrtovmach
added
RFC
It was very unclear to me that "must not contain leading zeroes" is referring to "non-negative integers" rather than to "A normal version number".
First (correct) interpretation would disallow 1.01.1, second (incorrect) would disallow 0.1.0.
I tried to make it more explicit here.