Minor formatting/markup tweaks #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(I believe this is a patch-level change. :P)
| @@ -327,7 +330,7 @@ The Semantic Versioning specification is authored by [Tom | |||
| Preston-Werner](http://tom.preston-werner.com), inventor of Gravatars and | |||
| cofounder of GitHub. | |||
|
|
|||
| If you'd like to leave feedback, please [open an issue on | |||
| If you'd like to leave feedback, please [open an Issue on | |||
There was a problem hiding this comment.
I was considering “Issues” a proper noun (as in “GitHub Issues”). Will change back to lowercase.
As per [comment](https://github.com/mojombo/semver/pull/301/files/08d32de1fbb01235c38c4ba299b7aa04f90665d2#r60998922) on my original Pull Request.
|
De-capitalized “issue”. :) |
|
ping |
jwdonahue
reviewed
Nov 19, 2017
| @@ -4,15 +4,15 @@ Semantic Versioning 2.0.0 | |||
| Summary | |||
| ------- | |||
|
|
|||
| Given a version number MAJOR.MINOR.PATCH, increment the: | |||
| Given a version number `MAJOR.MINOR.PATCH`, increment the: | |||
There was a problem hiding this comment.
The quotes are not needed around MAJOR.MINOR.PATCH and seem to be confusing. The all-caps seems to be sufficient.
jwdonahue
reviewed
Nov 19, 2017
|
|
||
| 1. MAJOR version when you make incompatible API changes, | ||
| 1. MINOR version when you add functionality in a backwards-compatible | ||
| 1. `MAJOR` version when you make incompatible API changes, |
There was a problem hiding this comment.
Why isn't all-caps sufficient?
jwdonahue
reviewed
Nov 19, 2017
|
Closing & re-opening to trigger CI |
alexandrtovmach
added
layout
|
I agree that this doesn't add clarity. |
|
I'm actually okay with wrapping with backticks examples of versions like |
qub1750ul
pushed a commit
to qub1750ul/versioning
that referenced
this pull request
Jul 10, 2021
Adjust RFC keywords in zh-TW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I believe this is a patch-level change. :P)