Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications regarding dots, hyphens, increments and major version … #402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BenjaminLefoul
Copy link

…increment requirements.

@BenjaminLefoul
Copy link
Author

BenjaminLefoul commented Oct 16, 2017

For very simple one-file software, this makes it explicitly possible to have all non-trivial (0.0.0 and 1.0.0) versions ever as X.0.0 with X represented as a 4-char string representing any number between 1000 and 9999. This is for better listing presentation. 8999 possible versions should be sufficient for such simple software.

@FichteFoll
Copy link

Making 1.0.0 only optionally define an API makes no sense since that is precisely the purpose of this version (or any version, in a way). Without a public API, semver has no use.

@BenjaminLefoul
Copy link
Author

But this does not imply that it is optional to have a public API, quite the contrary as per number 1. It only makes it optional to number said API 1.0.0.

Currently the requirement of (1) followed by the statement in (5) implies that the existence of version 1.0.0 is necessary, which I feel it shouldn't be.

@FichteFoll
Copy link

FichteFoll commented Oct 29, 2017

What do you gain from not having to number the version that defines the API as 1.0.0? If it's <1, then you are free to do whatever anyway because of (4). If it's >1, then what are you going to compare the previous versions to?

@BenjaminLefoul
Copy link
Author

BenjaminLefoul commented Oct 30, 2017

I'm only arguing that instead of splitting the version line at point 1 we split it at point X, where X is explicitly defined at the liberty of the developer (with perhaps a default at 1). But yeah, I guess people who don't want version 1.0.0 but still need semver compliance could just have 0.0.z forever and just increment the patch version, but it feels like a hack trying to avoid problems when semver was supposed to solve others.

It's not that important.

@jwdonahue
Copy link
Contributor

@BenjaminLefoul, if "it's not that important", please cancel/close this PR. It is highly unlikely to be accepted.

@alexandrtovmach
Copy link
Member

Closing & re-opening to trigger CI

@alexandrtovmach alexandrtovmach added RFC Request for comments state for next version update Update current idea/rule and removed proposal labels Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for comments state for next version update Update current idea/rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants