Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semver.md #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update semver.md #547

wants to merge 1 commit into from

Conversation

ajbogh
Copy link

@ajbogh ajbogh commented Jan 17, 2020

Clarified points 4 and 5.

Fixes #490

Clarified points 4 and 5.
@jwdonahue
Copy link
Contributor

If my product is not "ready for the public to use", why would I burn through SemVer version numbers at all? If I am not publishing the product, a build number should suffice.

@ajbogh
Copy link
Author

ajbogh commented Jan 17, 2020

@jwdonahue I appreciate your comment but I'm not entirely sure how it relates to the PR. Regarding version numbers, you're welcome to use any format but this change only entails the details of items 4 and 5. Other items describe using notations such as "-prerelease" and build numbers. In fact I'm using a package that uses "canary-xyz123" as a version number.

Again, this PR is only to clarify and improve items 4 and 5. There is still some leeway given with the verbiage, such as using the words "It is not recommended for the public". Just because someone does not recommend the usage doesn't mean it's off limits. We just want to point out that certain guarantees in code quality are not provided.

@jwdonahue
Copy link
Contributor

@ajbogh wrote:

We just want to point out that certain guarantees in code quality are not provided.

That's already obvious in the current spec. It does not require added emphasis.

@alexandrtovmach
Copy link
Member

Closing & re-opening to trigger CI

@alexandrtovmach alexandrtovmach added RFC Request for comments state for next version extend Brand new ideas/rules to add to the specification and removed proposal labels Jun 19, 2020
@adamralph
Copy link
Contributor

Something feels off with this. I'm not sure that recommendations for and against public use should form part of SemVer. After all, if something is not recommended for public use, why publish it?

@alexeyzimarev
Copy link

There are quite a few popular projects that avoid going 1.0 for the sake of flexibility to make breaking changes. Kubernetes was on 0.X for a while and used in production by hundreds of thousands. Hugo is another example, it is on 0.81 now and millions use it.

@adamralph
Copy link
Contributor

Something feels off with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extend Brand new ideas/rules to add to the specification RFC Request for comments state for next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify points 4 and 5 in Semver 2.0
6 participants