Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a regex compatible with Bash #724

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: add a regex compatible with Bash #724

wants to merge 2 commits into from

Conversation

dunglas
Copy link

@dunglas dunglas commented Jul 12, 2021

\d and capture groups aren't compatible with Bash. I added a compatible regex. I hope it will help.

@jwdonahue
Copy link
Contributor

Please add a link to regex101 showing your regex and the test data used for the other regex's.

@dunglas
Copy link
Author

dunglas commented Dec 5, 2021

@jwdonahue done.

jwdonahue
jwdonahue approved these changes Dec 5, 2021
View reviewed changes
Copy link
Contributor

@jwdonahue jwdonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for whatever that's worth.

@JohnTitor JohnTitor added RFC Request for comments state for next version extend Brand new ideas/rules to add to the specification labels Jul 23, 2022
@har7an har7an mentioned this pull request Jan 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwdonahue jwdonahue jwdonahue approved these changes

Assignees
No one assigned
Labels
extend Brand new ideas/rules to add to the specification RFC Request for comments state for next version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dunglas @jwdonahue @JohnTitor