Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift as a regex support system #955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kyle-Ye
Copy link

@Kyle-Ye Kyle-Ye commented Jun 21, 2023

Close #954

@JohnTitor
Copy link
Member

JohnTitor commented Jun 21, 2023

This itself looks good, but I don't think it's a good idea to list all the related systems/languages here (otherwise we would have to update them endlessly). We can probably tweak the text with "etc.", "for example,", or something like that.

@jwdonahue
Copy link
Contributor

There's also the testing problem. Adding specific languages implies that someone has tested them in those environments.

@Kyle-Ye
Copy link
Author

Kyle-Ye commented Jun 22, 2023

This itself looks good, but I don't think it's a good idea to list all the related systems/languages here (otherwise we would have to update them endlessly). We can probably tweak the text with "etc.", "for example,", or something like that.

Update the text with "etc."

And I agree we should not try to list all the related systems/languages here.

But according to the TIOBE ranking, Swift is in the same echelon as Go. So IMO it deserve a list name here. If you have different opinion, I can update the commit to only add "etc." wording.

@Kyle-Ye
Copy link
Author

Kyle-Ye commented Jun 22, 2023

There's also the testing problem. Adding specific languages implies that someone has tested them in those environments.

Yes, Swift is tested to support this regex. You can check it out with a Swift env locally or by using https://swiftregex.com

Swift has build-in Regex literals and Regex runtime support since Swift 5.7.

https://github.com/apple/swift-evolution/blob/main/proposals/0354-regex-literals.md

@enezmmt

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Swift as a Regex Support system
4 participants