Fix NPE when coercing nullable vestion (#186)

semver4j · Oct 9, 2023 · bf58e56 · bf58e56
1 parent 23c6e26
commit bf58e56
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/main/java/org/semver4j/Semver.java b/src/main/java/org/semver4j/Semver.java
@@ -82,10 +82,15 @@ public static Semver parse(@Nullable final String version) {
      */
     @Nullable
     public static Semver coerce(@Nullable final String version) {
+        if (version == null) {
+            return null;
+        }
+
         Semver semver = parse(version);
         if (semver != null) {
             return semver;
         }
+
         String coerce = Coerce.coerce(version);
         return parse(coerce);
     }

diff --git a/src/test/java/org/semver4j/SemverTest.java b/src/test/java/org/semver4j/SemverTest.java
@@ -797,6 +797,15 @@ static Stream<Arguments> coerceVersions() {
         );
     }
 
+    @Test
+    void shouldReturnNullWhenTryCoerceNullableVersion() {
+        //when
+        Semver semver = coerce(null);
+
+        //then
+        assertThat(semver).isNull();
+    }
+
     @Test
     void shouldCreateSemverWithHyphenInBuildSection() {
         //when