Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Template: Fix input in search and filter #605

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

UI Template: Fix input in search and filter #605

wants to merge 6 commits into from

Conversation

olecom
Copy link

@olecom olecom commented Feb 20, 2015

No description provided.

@olecom olecom changed the title Fix input in search and filter UI Template: Fix input in search and filter Feb 20, 2015
@nene
Copy link
Member

nene commented Feb 23, 2015

Hi.

Thanks for the contribution. But could you be so kind and describe briefly the bug that this pull request is supposed to fix.

I could go through the commits and figure it out by myself, but I think it should be your responsibility to convince me about the usefulness of this patch.

@olecom
Copy link
Author

olecom commented Feb 26, 2015

Right, sorry.

  1. Filter is noticeably slow (e.g. on laptops in battery saving mode or when OS is overloaded)
    thus it's a good idea to buffer input a bit and don't do filtering right from the first character
    btw, Search is deferred by basicSearchDelay

  2. both Filter and Search: input by context menu (mouse right click)
    when pasting text via mouse + context menu nothing happens (jsDuck in ExtJS 5.1):
    image

image

non changing behavior patch olecom@9eb91e2 allows isolated implementation of the fix in olecom@1a9be9d

  1. get rid of blind use of optimization killer arguments (can be skipped)

olecom referenced this pull request in suprojs/extjs-4.2 Jul 15, 2015
@olecom
docs "Filter class members": do search on mouse text insert via conte…
ffc8dbf 
…xt menu

Docs.view.cls.Toolbar: use `self` as ref to `this` component	 olecom/jsduck@9eb91e2
Filter class members: use 'change' event instead of 'keyup'   olecom/jsduck@1a9be9d
Docs.view.cls.Toolbar: Ext.toolbar.Toolbar.initComponent() has no arguments olecom/jsduck@dd68860

Signed-off-by: Oleg Verych <olecom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olecom @nene