Scoping Functions and Adding Multiple GL Context Support #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| branch.gl = gl; | ||
| branch.Utils = PhiloGL.$; | ||
| }; | ||
| }); |
There was a problem hiding this comment.
looks like this wrapper function never gets called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GL Contexts: Previously PhiloGL was only able to support a single GL context at a time. Thanks to some refactoring that is no longer the case. Commit 818b319 adds multiple context support so now we can create as many webGL canvases as we want with PhiloGL.
Scoping: The $ was previously polluting the global name space when I included the individual src files of PhiloGL directly so I scoped it to PhiloGL.$ and aliased $ to it inside each closure. Also the app and globalContext variables were removed from the top level global namespace. PhiloGL should now be the only addition to the top level global namespace.