Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Raptor as a submodule #11

Open
MitraDarja opened this issue Nov 2, 2021 · 1 comment
Open

Add Raptor as a submodule #11

MitraDarja opened this issue Nov 2, 2021 · 1 comment

Comments

@MitraDarja
Copy link
Collaborator

Add Raptor as a submodule to make the same comparison as in the Raptor paper.
Note: The search probably needs to be adapted to the different methods.

@MitraDarja
Copy link
Collaborator Author

Reasons to add Raptor:

  • The building process can be used without modification when providing a binary file with the precomputed submers
  • Actual access to Raptors performance

Reasons to not add Raptor:

  • Raptor is not a header library
  • Search needs to be adapted/written anew
  • There is no need for all its improvements like hibf, we are only interested in the accuracy

=> Instead of add Raptor as a submodule, we should use a simple ibf to determine FP and FN based on thresholds
(later we can also implement an adapted threshold)

@MitraDarja MitraDarja mentioned this issue Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant