Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foreign key detection when the target table is in another schema #627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mat813
Copy link
Sponsor Contributor

@mat813 mat813 commented Nov 2, 2022

constraint_schema ends up being the same schema than the source_schema, which is not good, as the target_schema of the target_table can be different, so actually use the target table schema.

constraint_schema ends up being the same schema than the source_schema,
which is not good, as the target_schema of the target_table can be
different, so actually use the target table schema.
@mat813
Copy link
Sponsor Contributor Author

mat813 commented Dec 7, 2022

poke @steveschmitt

@mat813
Copy link
Sponsor Contributor Author

mat813 commented Jan 30, 2023

Is there anything I need to do to make it go further ?

@ephys
Copy link
Member

ephys commented Jan 30, 2023

The issue on our end is that we don't currently have the manpower to work on this project. steveschmitt seems to have been inactive since december 2021 and he was the main maintainer of sequelize-auto

I'd love to get this project moving again but I'm already focused on the new version of Sequelize Core. The best thing that could happen to this project would be to find a new maintainer that is willing to take care of sequelize-auto

I'm trying to find the time to overhaul the test suite so we can add regression tests for things like this, but the codebase is very 2013. If this scenario were tested, it'd be much easier for us to merge it

@mat813
Copy link
Sponsor Contributor Author

mat813 commented Jan 30, 2023

Well, I would volunteer myself to maintain this, but, well, I am not sure what the workload would be, and if I have enough brain cycles to do it.
(And yes, the codebase for this is old)
I will try to figure out a way to test this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants