fix(mssql): omit empty pk values for upsert

sequelize · May 24, 2020 · 0c10665 · 0c10665
1 parent 9d8a7d3
commit 0c10665
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/lib/dialects/mssql/query-interface.js b/lib/dialects/mssql/query-interface.js
@@ -57,6 +57,17 @@ class MSSqlQueryInterface extends QueryInterface {
       wheres.push(where);
     }
 
+    const primaryKeys = Object.values(model.primaryKeys).map(item => item.field);
+
+    for (const primaryKeyField of primaryKeys) {
+      if (primaryKeyField in insertValues && insertValues[primaryKeyField] === null) {
+        delete insertValues[primaryKeyField];
+      }
+      if (primaryKeyField in updateValues && updateValues[primaryKeyField] === null) {
+        delete updateValues[primaryKeyField];
+      }
+    }
+
     // Lets combine unique keys and indexes into one
     let indexes = Object.values(model.uniqueKeys).map(item => item.fields);
     indexes = indexes.concat(Object.values(model._indexes).filter(item => item.unique).map(item => item.fields));