fix: accept undefined in where (#15703)

sequelize · Feb 22, 2023 · 13f2e89 · 13f2e89
1 parent d9e0728
commit 13f2e89
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/dialects/abstract/query-generator.js b/src/dialects/abstract/query-generator.js
@@ -2826,7 +2826,7 @@ class QueryGenerator {
       }
       throw new Error('Support for literal replacements in the `where` object has been removed.');
     }
-    if (smth === null) {
+    if (smth == null) {
       return this.whereItemsQuery(smth, {
         model: factory,
         prefix: prepend && tableName

diff --git a/test/unit/sql/get-where-conditions.test.js b/test/unit/sql/get-where-conditions.test.js
@@ -11,4 +11,16 @@ describe('QueryGenerator#getWhereConditions', () => {
       queryGenerator.getWhereConditions(new Date(), User.getTableName(), User);
     }).to.throw('Unsupported where option value');
   });
+
+  it('ignores undefined', () => {
+    const User = sequelize.define('User');
+
+    expect(queryGenerator.getWhereConditions(undefined, User.getTableName(), User)).to.eq('');
+  });
+
+  it('ignores null', () => {
+    const User = sequelize.define('User');
+
+    expect(queryGenerator.getWhereConditions(undefined, User.getTableName(), User)).to.eq('');
+  });
 });