Fix MSSQL returning values for bulkUpdate

- bulkUpdate will now return the updates if options.returning is true.
- updateQuery will now take options.returning into account
- updateQuery removed duplicate setting check
- Fix documentation for model.update

lib/dialects/abstract/query-generator.js

@@ -365,7 +365,7 @@ class QueryGenerator {
     }
 
     if (this._dialect.supports.returnValues) {
-      if (this._dialect.supports.returnValues.output) {
+      if (this._dialect.supports.returnValues.output && options.returning) {
         // we always need this for mssql
         outputFragment = ' OUTPUT INSERTED.*';
 
@@ -393,7 +393,7 @@ class QueryGenerator {
 
           suffix += selectFromTmp;
         }
-      } else if (this._dialect.supports.returnValues && options.returning) {
+      } else if (options.returning) {
         // ensure that the return output is properly mapped to model fields.
         options.mapToModel = true;
         suffix += ' RETURNING *';

lib/dialects/mssql/query.js

@@ -210,7 +210,10 @@ class Query extends AbstractQuery {
       return data[0];
     }
     if (this.isBulkUpdateQuery()) {
-      return data.length;
+      if (this.options.returning)
+        return this.handleSelectQuery(data);
+      else
+        return data.length;
     }
     if (this.isBulkDeleteQuery()) {
       return data[0] && data[0].AFFECTEDROWS;

test/unit/sql/update.test.js

@@ -53,7 +53,7 @@ describe(Support.getTestDialectTeaser('SQL'), () => {
 
       expectsql(sql.updateQuery(User.tableName, { username: 'new.username' }, { username: 'username' }, { limit: 1 }), {
         query: {
-          mssql: 'UPDATE TOP(1) [Users] SET [username]=$1 OUTPUT INSERTED.* WHERE [username] = $2',
+          mssql: 'UPDATE TOP(1) [Users] SET [username]=$1 WHERE [username] = $2',
           mariadb: 'UPDATE `Users` SET `username`=$1 WHERE `username` = $2 LIMIT 1',
           mysql: 'UPDATE `Users` SET `username`=$1 WHERE `username` = $2 LIMIT 1',
           sqlite: 'UPDATE `Users` SET `username`=$1 WHERE rowid IN (SELECT rowid FROM `Users` WHERE `username` = $2 LIMIT 1)',

types/lib/model.d.ts

@@ -2043,7 +2043,7 @@ export abstract class Model<T = any, T2 = any> extends Hooks {
   /**
    * Update multiple instances that match the where options. The promise returns an array with one or two
    * elements. The first element is always the number of affected rows, while the second element is the actual
-   * affected rows (only supported in postgres with `options.returning` true.)
+   * affected rows (only supported in postgres and mssql with `options.returning` true.)
    */
   public static update<M extends Model>(
     this: { new (): M } & typeof Model,