feat: added automatic schema creation to sequelize.sync() and model.c…

…reate()
sequelize · Apr 26, 2024 · a6b3c69 · a6b3c69
1 parent c8729db
commit a6b3c69
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 0 deletions.
diff --git a/packages/core/src/model.js b/packages/core/src/model.js
@@ -1916,6 +1916,13 @@ ${associationOwner._getAssociationDebugList()}`);
   static async create(values, options) {
     options = cloneDeep(options) ?? {};
 
+    if (options.schema) {
+      const schemas = await this.queryInterface.listSchemas();
+      if (!schemas.includes(options.schema)) {
+        await this.queryInterface.createSchema(options.schema);
+      }
+    }
+
     return await this.build(values, {
       isNewRecord: true,
       attributes: options.fields,

diff --git a/packages/core/src/sequelize.js b/packages/core/src/sequelize.js
@@ -456,6 +456,13 @@ Use Sequelize#query if you wish to use replacements.`);
       );
     }
 
+    if (options.schema) {
+      const schemas = await this.queryInterface.listSchemas();
+      if (!schemas.includes(options.schema)) {
+        await this.queryInterface.createSchema(options.schema);
+      }
+    }
+
     if (options.hooks) {
       await this.hooks.runAsync('beforeBulkSync', options);
     }

diff --git a/packages/core/test/integration/model/create/include.test.js b/packages/core/test/integration/model/create/include.test.js
@@ -533,6 +533,30 @@ describe(Support.getTestDialectTeaser('Model'), () => {
         expect(persistedUser.jobs).to.be.ok;
         expect(persistedUser.jobs.length).to.equal(2);
       });
+      it('should create a schema if the schema does not exist when create', async function () {
+        try {
+          const before = await this.sequelize.queryInterface.listSchemas();
+          const User = this.sequelize.define('User', {
+            username: DataTypes.STRING,
+          });
+          await this.sequelize.sync({ force: true });
+          await User.create(
+            {
+              username: 'John',
+            },
+            {
+              schema: 'temp',
+            },
+          );
+          const after = await this.sequelize.queryInterface.listSchemas();
+          const difference = after.length - before.length;
+          expect(difference).to.equal(1);
+        } catch (error) {
+          if (!error.message.includes('Schemas are not supported in')) {
+            throw error;
+          }
+        }
+      });
     });
   });
 });
diff --git a/packages/core/test/integration/model/sync.test.js b/packages/core/test/integration/model/sync.test.js
@@ -687,6 +687,14 @@ describe(getTestDialectTeaser('Model.sync & Sequelize#sync'), () => {
       });
       expect(results).to.have.length(1);
     });
+
+    it('should create a schema if the schema does not exist when syncing', async () => {
+      const before = await this.sequelize.queryInterface.listSchemas();
+      await sequelize.sync({ schema: 'temp' });
+      const after = await this.sequelize.queryInterface.listSchemas();
+      const difference = after.length - before.length;
+      expect(difference).to.equal(1);
+    });
   }
 
   // TODO add support for db2 and mssql dialects