Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: types/type-helpers/set-required.d.ts not included in package #11973

Closed
kf6kjg opened this issue Mar 3, 2020 · 1 comment
Closed

bug: types/type-helpers/set-required.d.ts not included in package #11973

kf6kjg opened this issue Mar 3, 2020 · 1 comment
Assignees
Labels
type: bug type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.

Comments

@kf6kjg
Copy link
Contributor

kf6kjg commented Mar 3, 2020

In commit 365d7c3 the following line was added to types/lib/query-interface.d.ts, along with the matching folder and file.

import { SetRequired } from './../type-helpers/set-required';

However when I npm install sequelize@6.0.0-beta.5 I get a compilation error:

node_modules/sequelize/types/lib/query-interface.d.ts:7:29 - error TS2307: Cannot find module './../type-helpers/set-required'.

A manual inspection of the filesystem shows:

$ ls -1p node_modules/sequelize/types/lib
associations/
connection-manager.d.ts
data-types.d.ts
deferrable.d.ts
errors.d.ts
hooks.d.ts
index-hints.d.ts
instance-validator.d.ts
model.d.ts
model-manager.d.ts
operators.d.ts
promise.d.ts
query-interface.d.ts
query-types.d.ts
sequelize.d.ts
sql-string.d.ts
table-hints.d.ts
transaction.d.ts
utils/
utils.d.ts
$ ls -1p node_modules/sequelize/types/lib/..
index.d.ts
lib/
@papb papb self-assigned this Mar 4, 2020
@papb papb added status: understood For issues. Applied when the issue is understood / reproducible. type: bug type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. status: wip For issues and PRs. Applied when the PR is not ready yet / when work to close the issue has started. and removed status: understood For issues. Applied when the issue is understood / reproducible. labels Mar 4, 2020
@papb
Copy link
Member

papb commented Mar 17, 2020

Closed by #12000

@papb papb closed this as completed Mar 17, 2020
@papb papb removed the status: wip For issues and PRs. Applied when the PR is not ready yet / when work to close the issue has started. label Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants