Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): fix missing file in npm #11974

Closed
wants to merge 1 commit into from
Closed

fix(typings): fix missing file in npm #11974

wants to merge 1 commit into from

Conversation

papb
Copy link
Member

@papb papb commented Mar 4, 2020

I made a mistake on PR #11844 which was not noticed due to how our current TS tests are performed. In short it broke TS usage for v6.0.0-beta.5.

This is a quick fix to that. In the future we shall improve our TS tests (there is even a PR for this right now) and catch these things.

Please merge ASAP so users can update to latest beta and use TS.

Closes #11973

@papb papb added type: bug P1: important For issues and PRs. type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. labels Mar 4, 2020
@papb papb requested a review from SimonSchick March 4, 2020 10:44
@papb
Copy link
Member Author

papb commented Mar 13, 2020

ping @SimonSchick @sushantdhiman

@sushantdhiman
Copy link
Contributor

Sorry @papb I just merged a similar PR #12000, Closing this

@sushantdhiman sushantdhiman deleted the papb-patch-1 branch March 16, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important For issues and PRs. type: bug type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: types/type-helpers/set-required.d.ts not included in package
3 participants