New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mssql): upsert query with falsey values #12453
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12453 +/- ##
==========================================
+ Coverage 96.44% 96.46% +0.02%
==========================================
Files 95 95
Lines 9192 9192
==========================================
+ Hits 8865 8867 +2
+ Misses 327 325 -2
Continue to review full report at Codecov.
|
appears that the |
You can open this PR for |
@sushantdhiman thanks! The project that needs this fix is currently on |
@patrickcarnahan I would like to avoid pushing too many releases for v5 but bug fixes are allowed. I have merged PR for |
@patrickcarnahan @sushantdhiman this bug exists in |
@srikanth2042 No, |
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
properly determines if a value used in a filter clause for upsert is relevant. currently there is a bug where it treats "falsey" values as not being specified, making it impossible to use something like a default value of
0
in a unique key and then filter by that value.closes #11902
closes #11684