Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): upsert query with falsey values (#12453) #12504

Closed

Conversation

patrickcarnahan
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

cherry-pick of #12453

properly determines if a value used in a filter clause for upsert is relevant. currently there is a bug where it treats "falsey" values as not being specified, making it impossible to use something like a default value of 0 in a unique key and then filter by that value.

closes #11902
closes #11684

@patrickcarnahan
Copy link
Contributor Author

@sushantdhiman thanks for the offer to accept this in v5. after speaking with the azurite project maintainers it would be very helpful to have this fix backported to v5 in order to reduce risk for the change on their side.

@patrickcarnahan
Copy link
Contributor Author

☝️ was a no-op amend to trigger the appveyor check again. looks like it failed to download the code coverage script. i'll try amending one more time.

@patrickcarnahan
Copy link
Contributor Author

🤷 not sure if there is anything I can do. Looks like something with coverage in the v5 branch isn't working properly.

@patrickcarnahan
Copy link
Contributor Author

@sushantdhiman just wanted to check in on this and see if this is still a change you are willing to take to v5.

@patrickcarnahan
Copy link
Contributor Author

@papb i haven't heard back from @sushantdhiman in a few weeks (maybe he's on vacation or something?) - any chance you're willing to review this backport into v5 discussed here? #12453 (comment)

@patrickcarnahan
Copy link
Contributor Author

Consumed v6 in azurite so no reason to keep this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant