fix(model): handle true timestamp fields correctly
#12580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Model.init method to accept only string and boolean values. Also, prevent a column named `true` from being created on the model whenever any timestamp fields (viz. 'createdAt', 'updatedAt', 'deletedAt') is set to `true` Closes sequelize#12551
Added tests to check the following: - Model.init throws Error when any timestamp field has value other than string or boolean - Model.init doesn't create a column named `true` when any timestamp field is set to true
Codecov Report
@@ Coverage Diff @@
## master #12580 +/- ##
==========================================
- Coverage 96.33% 95.85% -0.48%
==========================================
Files 95 92 -3
Lines 9256 9057 -199
Branches 90 90
==========================================
- Hits 8917 8682 -235
- Misses 322 358 +36
Partials 17 17
Continue to review full report at Codecov.
|
papb
changed the title
truetrue timestamp fields correctly
papb
approved these changes
Aug 1, 2020
|
Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future! Fantastic work!! |
papb
added a commit
that referenced
this pull request
Aug 1, 2020
Co-authored-by: Pedro Augusto de Paula Barbosa <papb1996@gmail.com>
papb
added a commit
that referenced
this pull request
Aug 1, 2020
Co-authored-by: Pedro Augusto de Paula Barbosa <papb1996@gmail.com> Co-authored-by: Vishal Sood <vishalsood1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Model.initmethod to accept onlystringandbooleanvalues for the timestamp fields; throw anErrorif some other value is passed"true"from being created on the model whenever any timestamp fields (viz.createdAt,updatedAt,deletedAt) is set totrueFixes #12551