Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): handle true timestamp fields correctly (#12580) #12581

Merged
merged 2 commits into from
Aug 1, 2020

Conversation

papb
Copy link
Member

@papb papb commented Aug 1, 2020

This is a cherry-pick from #12580 targeting the v6 branch, so that the fix can land in v6.

vishal-sood and others added 2 commits August 1, 2020 19:22
Co-authored-by: Pedro Augusto de Paula Barbosa <papb1996@gmail.com>
@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #12581 into v6 will increase coverage by 0.40%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v6   #12581      +/-   ##
==========================================
+ Coverage   95.97%   96.38%   +0.40%     
==========================================
  Files          92       95       +3     
  Lines        8953     9162     +209     
==========================================
+ Hits         8593     8831     +238     
+ Misses        360      331      -29     
Impacted Files Coverage Δ
lib/model.js 96.58% <87.50%> (-0.06%) ⬇️
lib/dialects/postgres/connection-manager.js 92.30% <0.00%> (-3.50%) ⬇️
lib/dialects/mariadb/index.js 100.00% <0.00%> (ø)
lib/dialects/mariadb/connection-manager.js 100.00% <0.00%> (ø)
lib/dialects/mariadb/query.js 87.96% <0.00%> (ø)
lib/sequelize.js 95.87% <0.00%> (+0.63%) ⬆️
lib/dialects/abstract/query-interface.js 94.08% <0.00%> (+1.86%) ⬆️
lib/dialects/mariadb/data-types.js 100.00% <0.00%> (+52.63%) ⬆️
lib/dialects/mariadb/query-generator.js 100.00% <0.00%> (+81.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c99ba0...1929905. Read the comment docs.

@papb papb merged commit 490db41 into v6 Aug 1, 2020
@papb papb deleted the cherrypick-12580-v6 branch August 1, 2020 23:27
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 6.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants