Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HasMany): add 'createRoles' method #11512

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conversation

ssgiant
Copy link
Contributor

@ssgiant ssgiant commented Oct 5, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Added type definition for 'createRoles' function generation for the Issue#11372

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #11512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11512   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          94       94           
  Lines        9182     9182           
=======================================
  Hits         8839     8839           
  Misses        343      343

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78602d1...4e887e8. Read the comment docs.

@sushantdhiman sushantdhiman merged commit fafe375 into sequelize:master Oct 9, 2019
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.19.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@papb
Copy link
Member

papb commented Oct 9, 2019

Wait, this PR added the typings but the implementation itself doesn't even exist yet, does it?

The createMultiple is not implemented, is it?

@sushantdhiman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants