Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(postgres): change returning option to only return model attributes #11526

Merged
merged 2 commits into from
Oct 19, 2019
Merged

feat(postgres): change returning option to only return model attributes #11526

merged 2 commits into from
Oct 19, 2019

Commits on Oct 16, 2019

  1. fix(findOrCreate): ensure option returning is true on insert

    @Americas
    Americas committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    6f4ebbd View commit details
    Browse the repository at this point in the history

  2. feat(postgres): change returning option to only return model attributes 

    If an underlying table has columns that don't exist in the model,
when using `returning: true` the instance will be created with these
extra attributes. This change alters this behavior to only return the
fields defined in the model, provided a model definition is passed.

BREAKING CHANGE: setting `returning: true` will no longer create
attributes on the instance that are not defined in the model.

The old default behavior, if desired, can be used by changing the:

`returning: true`

to

`returning: ['*']`
    @Americas
    Americas committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    498a1f9 View commit details
    Browse the repository at this point in the history