fix(types): include 'as' in IncludeThroughOptions definition

[mmena1]

Pull Request check-list

Please make sure to review and check all of these items:

• Does npm run test or npm run test-DIALECT pass with this change (including linting)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Have you added new tests to prevent regressions?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Did you update the typescript typings accordingly (if applicable)?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

This will add as property to the IncludeThroughOptions definition.
Closes #11185

[papb]

Hello, thanks for the PR, I have a question in the issue though, please take a look :)

[papb]

Since this is currently undocumented, I don't think this should be merged as-is... @mrcrow85 would you be willing to update the docs with this fact as well?

In fact, can you first create an sscce showing this thing working? The issue's OP does not have time, thanks!

[mmena1]

@papb Sure! I can do that

[papb]

Thanks for the work so far @mrcrow85, I have some requests before we can merge this. Since this feature seems a bit obscure to me, I think more has to be done:

• This has to be documented correctly, by adding a new line here
• I would like to see a test for this behavior, this feature seems untested currently, so please add a test for it here

What do you think?

[mmena1]

@papb Don't we also need to update the docs here (on the findAll example)?

[papb]

@mrcrow85 Not every feature is explained in the guides/tutorials, so I wouldn't say it is strictly necessary. Also, since I happen to be in the middle of rewriting the guides already, don't worry about it.

[codecov]

Codecov Report

Merging #11624 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11624   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          94       94           
  Lines        9190     9190           
=======================================
  Hits         8847     8847           
  Misses        343      343

Impacted Files	Coverage Δ
lib/model.js	96.54% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ba131...6576cdd. Read the comment docs.

[mmena1]

@papb Does the codecov report is ok? Seeing 21% less coverage really worries me.

[mmena1]

@papb Does the codecov report is ok? Seeing 21% less coverage really worries me.

Ok, nevermind. It fixed itself 🤔

[papb]

Thanks @mrcrow85, great work!