New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #11726 - correct the overloaded method order #11727
Conversation
When methods are overloaded, such that the different parameters are extensions of each other, the most specific signatures must come first.
Codecov Report
@@ Coverage Diff @@
## master #11727 +/- ##
==========================================
+ Coverage 96.26% 96.26% +<.01%
==========================================
Files 94 94
Lines 9190 9191 +1
==========================================
+ Hits 8847 8848 +1
Misses 343 343
Continue to review full report at Codecov.
|
I am not experiencing this issue at the moment, can you please provide a repro before we merge this? |
Sure; there's one in the attached issue #11726 |
In addition, the discussion the led me to this conclusion is available in this issue: microsoft/TypeScript#35472 |
I'm convinced, I think this should be merged, even if this was just a refactor (which it is not), since I agree that more specific overloads should come first (even for readability only). And surely merging this can't be harmful, can it? @SimonSchick can we merge this? |
No description provided.