Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postgres): idle_in_transaction_session_timeout connection option #11775

Merged

Conversation

aheuermann
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Exposing the postgres idle_in_transaction_session_timeout connection parameter. It was added in node-postgres v7.17.0 and only exposed in postgres v10 and greater.

Not sure if it is possible or the best way to write a test for this. So let me know if you have ideas.

Thanks!

@aheuermann aheuermann force-pushed the idle_in_transaction_session_timeout branch from 7900781 to 0e110af Compare January 10, 2020 03:04
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #11775 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11775   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          94       94           
  Lines        9191     9191           
=======================================
  Hits         8848     8848           
  Misses        343      343
Impacted Files Coverage Δ
lib/model.js 96.54% <ø> (ø) ⬆️
lib/sequelize.js 95.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e110af...9ef67ae. Read the comment docs.

@papb papb added dialect: postgres For issues and PRs. Things that involve PostgreSQL (and do not involve all dialects). status: awaiting maintainer type: feature For issues and PRs. For new features. Never breaking changes. labels Jan 17, 2020
@sushantdhiman sushantdhiman merged commit fbd19d9 into sequelize:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialect: postgres For issues and PRs. Things that involve PostgreSQL (and do not involve all dialects). type: feature For issues and PRs. For new features. Never breaking changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants