Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlite): moving 'fs-jetpack' back to devDependencies #11861

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

multum
Copy link
Contributor

@multum multum commented Jan 23, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Resolves conversation #11853

Moving fs-jetpack back to devDependencies and using fs.mkdirSync(path, { recursive: true }) instead of jetpack.dir(path)

using recursive 'fs.mkdirSync()' instead of 'jetpack.dir()'
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #11861 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11861   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          94       94           
  Lines        9209     9209           
=======================================
  Hits         8866     8866           
  Misses        343      343
Impacted Files Coverage Δ
lib/dialects/sqlite/connection-manager.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc9685...9541eb7. Read the comment docs.

Copy link
Member

@papb papb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! You just accidentally added a binary file to the commit:

test/integration/dialects/sqlite/0.40058070463297746_test_directory/0.3561808589746669_test.sqlite

Please remove that and then LGTM

@papb papb added status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action type: other For issues and PRs. Something that does not fit in any of the other "type:" labels. labels Jan 23, 2020
@papb papb merged commit 6837a17 into sequelize:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants