New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(postgres): minify include aliases over limit #11940
feat(postgres): minify include aliases over limit #11940
Conversation
Can't see the Codecov details, someone might be able to help me |
Codecov Report
@@ Coverage Diff @@
## master #11940 +/- ##
===========================================
- Coverage 96.23% 86.05% -10.18%
===========================================
Files 95 90 -5
Lines 9196 8816 -380
===========================================
- Hits 8850 7587 -1263
- Misses 346 1229 +883
Continue to review full report at Codecov.
|
2c14f98
to
a3a4471
Compare
👍 Looking forward to having this merged. Since creating the issue, I've found a few more cases where our project is suffering from the length limit in the FROM clause. And it's becoming an issue having to put in hacks to get around the problem. Any chance this will be merged soon? What are the next steps? |
I am waiting for a review and then hoping the tests pass |
I'm happy to see this merged. This will remove a lot of hackery from our codebase. Thanks for your work on it @mrrinot. Question: will this merge be included in a v5 release? Or just a future v6 release? |
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Proposal to make the
minifyAliases
option also alias includes that go over the 63 POSTGRES character limit.Closes #11937