Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): count() code generation for distinct rows #11946

Merged
merged 1 commit into from
Feb 21, 2020
Merged

fix(model): count() code generation for distinct rows #11946

merged 1 commit into from
Feb 21, 2020
+18 −1

Commits on Feb 20, 2020

  1. fix(model): count() code generation for distinct rows 

    Add code to count() to cause it to create valid SQL when distinct=true and col is unspecified or "*". Otherwise the SQL generated is COUNT(DISTINCT(*)), which is invalid. Issues referenced below were already closed, but the issue hadn't actually been fixed, and it _keeps coming up_.

Closes: sequelize#2713, sequelize#6404, sequelize#6418, sequelize#7344
    @TimMensch
    TimMensch committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    e35a142 View commit details
    Browse the repository at this point in the history