fix(model): fix unchained promise in association logic in bulkCreate #12163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12163 +/- ##
==========================================
- Coverage 96.34% 96.32% -0.03%
==========================================
Files 95 95
Lines 9203 9203
==========================================
- Hits 8867 8865 -2
- Misses 336 338 +2
Continue to review full report at Codecov.
|
| @@ -2642,7 +2642,7 @@ class Model { | |||
| const associationInstance = createdAssociationInstances[idx]; | |||
| const instance = associationInstanceIndexToInstanceMap[idx]; | |||
|
|
|||
| instance[include.association.accessors.set](associationInstance, { save: false, logging: options.logging }); | |||
| await include.association.set(instance, associationInstance, { save: false, logging: options.logging }); | |||
There was a problem hiding this comment.
save: false, means this will not return promise. So await is not useful here. Why accessors is being removed?
There was a problem hiding this comment.
All of the set function were converted to async so they always return a promise now.
Using accessors.set was only used to look up the instance set method which is effectively just a proxy (see helpers.js:64) seemed redundant to me 🤷♂️
There was a problem hiding this comment.
Ah yes, it is an async method now. That make sense
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Found this while messing around in code base.
Wrote no test due to high complexity of function, plus nothing seems to be failing as a result...