Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove remaining bluebird references #12167

Merged
merged 2 commits into from Apr 25, 2020

Conversation

SimonSchick
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

  • Removes bluebird references from docs
  • Removes bluebird typings
  • Cleans up some unused imports in typings where bluebird was removed

@SimonSchick
Copy link
Contributor Author

Oh look the flaky row locking test again >.>

@sushantdhiman
Copy link
Contributor

Oh look the flaky row locking test again >.>

Yes annoying

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #12167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12167   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          95       95           
  Lines        9190     9190           
=======================================
  Hits         8854     8854           
  Misses        336      336           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7610345...334ad16. Read the comment docs.

@SimonSchick SimonSchick merged commit 5a807c5 into master Apr 25, 2020
@SimonSchick SimonSchick deleted the chore/remove-bluebird-leftovers branch April 25, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants