Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): specified 'this' for getters and setters in fields #12370

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

knoid
Copy link
Contributor

@knoid knoid commented Jun 14, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

I'm bringing #11648 into v5.

Added typings for this on getters and setters in attribute definitions.

@sushantdhiman sushantdhiman merged commit 7fba668 into sequelize:v5 Jun 14, 2020
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.21.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants