Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (mssql): bulkUpdate returning values #12410

Merged
merged 5 commits into from
Jun 26, 2020
Merged

fix (mssql): bulkUpdate returning values #12410

merged 5 commits into from
Jun 26, 2020

Commits on Jun 25, 2020

  1. Fix MSSQL returning values for bulkUpdate 

    - bulkUpdate will now return the updates if options.returning is true.
- updateQuery removed duplicate setting check
- Fix documentation for model.update
    @ShaharHD
    ShaharHD committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    8ce23d6 View commit details
    Browse the repository at this point in the history

  2. Fix lint error

    @ShaharHD
    ShaharHD committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    8e0b440 View commit details
    Browse the repository at this point in the history

  3. Addional fixes based on master branch 

    Reference for change is based on sequelize#12260

- use rowCount intead of data.length when not returning data
    @ShaharHD
    ShaharHD committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    2153218 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Add test for returnValues.output true

    @ShaharHD
    ShaharHD committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    6b72fe2 View commit details
    Browse the repository at this point in the history

  2. Update query-generator.js

    @sushantdhiman
    sushantdhiman committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    eca897e View commit details
    Browse the repository at this point in the history